Skip to content

fix: resolve assets imported with require#6159

Merged
sheremet-va merged 4 commits intovitest-dev:mainfrom
sheremet-va:fix/dont-fail-require-asset
Jul 18, 2024
Merged

fix: resolve assets imported with require#6159
sheremet-va merged 4 commits intovitest-dev:mainfrom
sheremet-va:fix/dont-fail-require-asset

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Jul 18, 2024

Description

This PR makes it so require('*.png') and other asset types supported by Vite, don't fail in Node.js

By default, we assume the same hevaviour that Vite has: require('.png') returns a filepath

Closes #3809

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va changed the title feat: resolve assets imported with require fix: resolve assets imported with require Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments