fix: resolve assets imported with require#6159
Merged
sheremet-va merged 4 commits intovitest-dev:mainfrom Jul 18, 2024
Merged
Conversation
requirerequire
This was referenced Aug 12, 2024
This was referenced Aug 12, 2024
This was referenced Aug 28, 2024
This was referenced Sep 10, 2024
This was referenced Sep 12, 2024
Closed
This was referenced Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it so
require('*.png')and other asset types supported by Vite, don't fail in Node.jsBy default, we assume the same hevaviour that Vite has:
require('.png')returns a filepathCloses #3809
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.