Skip to content

Conversation

@sheremet-va
Copy link
Member

Description

Closes #5481

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 173df0f
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6855627055242500085f5b30
😎 Deploy Preview https://deploy-preview-8200--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va merged commit 1e60c4f into vitest-dev:main Jun 20, 2025
24 of 26 checks passed
@sheremet-va sheremet-va deleted the fix/deprecate-remove-node branch June 20, 2025 15:09
@nvie
Copy link

nvie commented Oct 3, 2025

@sheremet-va Would it be possible to backport this change to 3.2.x? We've been running into this issue from using @cloudflare/vitest-pool-workers (for which it's important that @types/node don't get imported as well).

@sheremet-va
Copy link
Member Author

@sheremet-va Would it be possible to backport this change to 3.2.x? We've been running into this issue from using @cloudflare/vitest-pool-workers (for which it's important that @types/node don't get imported as well).

This is a breaking change, so we cannot backport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using vitest/importMeta leaks Node types to web applications

2 participants