Skip to content

Conversation

@mrginglymus
Copy link
Contributor

@mrginglymus mrginglymus commented Oct 7, 2025

Description

Fix removal of the playwright-core/types/protocol export.

Should fix #8671 for v3

Unfortunately, the playwright.d.ts file is not type checked owing to skipLibCheck being true.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ab9069
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68e564a401b1d2000807b030
😎 Deploy Preview https://deploy-preview-8675--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mrginglymus mrginglymus changed the title Re-export CDP Session directly from playwright fix: re-export CDP Session directly from playwright Oct 9, 2025
sheremet-va
sheremet-va previously approved these changes Oct 12, 2025
Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sheremet-va sheremet-va changed the base branch from v3 to main October 12, 2025 11:04
@sheremet-va sheremet-va dismissed their stale review October 12, 2025 11:04

The base branch was changed.

@sheremet-va
Copy link
Member

Please, merge the conflicts, we don't do backports without the fix being in main. Also, v3 branch is for v3.0.

@mrginglymus
Copy link
Contributor Author

@sheremet-va raised #8702 for v4. Given two of the three files are new in v4 I'll leave this branch around for the backport to v3 as it's un-cherry-pickable.

@mrginglymus
Copy link
Contributor Author

Thanks for merging the other PR @sheremet-va - what would be the process for getting this fixed in v3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playwright 1.56.0 removes Protocol export from playwright-core

2 participants