Skip to content

Conversation

@nozomuikuta
Copy link
Contributor

Description

Resolves #7731

I just changed default generics type parameter, from unknown to any, as described in the issue.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d1785cc
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68ee73d14682bd00072df7e0
😎 Deploy Preview https://deploy-preview-8713--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nozomuikuta nozomuikuta changed the title docs: change default generics type parameter of CustomMatchers fix: change default generics type parameter of CustomMatchers Oct 14, 2025
@nozomuikuta
Copy link
Contributor Author

Hmm, I'm not sure why some CI fails...

@sheremet-va
Copy link
Member

sheremet-va commented Oct 21, 2025

I think we should instead recommend using Matchers interface, and deprecate this one. Matchers interface is applied to expect.extend and expect.to* too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggesting R = unknown for custom matchers makes asymmetric matchers error

2 participants