fix: use optimizeDeps.rolldownOptions to fix depreated warning + fix ssr.external: true
#9121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
changed the title
optimizeDeps.rolldownOptions to fix depreated warningoptimizeDeps.rolldownOptions to fix depreated warning + fix ssr.external: true
hi-ogawa
commented
Nov 28, 2025
| // https://github.com/vitejs/vite/pull/20502 | ||
| if (name === 'ssr') { | ||
| delete config.ssr?.noExternal | ||
| delete config.ssr?.external |
Contributor
Author
There was a problem hiding this comment.
This is to fix a following error https://github.com/vitest-dev/vitest/actions/runs/19751896072/job/56596264117?pr=9121#step:8:800
FAIL test/vite-ssr-resolve.test.ts > VitestResolver with Vite SSR config in deprecated style > handles ssr.resolve.external as true
Error: Value is non of these types `True`, `Array<T>`, on BindingViteResolvePluginConfig.external
Similar to ssr.noExternal, Vitest intend to fully overwrite through environments.ssr.resolve.external, so legacy ssr.external can be reset here.
I created a fix on Vite too vitejs/vite#21164
sheremet-va
approved these changes
Nov 28, 2025
hi-ogawa
deleted the
11-28-fix_use_optimizedeps.rolldownoptions_to_fix_depreated_warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #8754
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.