Skip to content

fix: don't propagate nested aroundEach/All errors but aggregate them on runner #9673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 2 commits into from
Feb 16, 2026
Merged

fix: don't propagate nested aroundEach/All errors but aggregate them on runner #9673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a1adf
fix: preserve nested around hook failures and add regressions
hi-ogawa Feb 16, 2026
00d1ec4
fix: fix errors order
hi-ogawa Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions packages/runner/src/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ async function callAroundHooks<THook extends Function>(
return
}

const hookErrors: unknown[] = []

const createTimeoutPromise = (
timeout: number,
phase: 'setup' | 'teardown',
Expand Down Expand Up @@ -352,23 +354,13 @@ async function callAroundHooks<THook extends Function>(
setupTimeout.clear()

// Run inner hooks - don't time this against our teardown timeout
let nextError: { value: unknown } | undefined
try {
await runNextHook(index + 1)
}
catch (value) {
nextError = { value }
}
await runNextHook(index + 1).catch(e => hookErrors.push(e))

// Start teardown timer after inner hooks complete - only times this hook's teardown code
teardownTimeout = createTimeoutPromise(timeout, 'teardown', stackTraceError)

// Signal that use() is returning (teardown phase starting)
resolveUseReturned()

if (nextError) {
throw nextError.value
}
}

// Start setup timeout
Expand Down Expand Up @@ -422,7 +414,11 @@ async function callAroundHooks<THook extends Function>(
}
}

await runNextHook(0)
await runNextHook(0).catch(e => hookErrors.push(e))

if (hookErrors.length > 0) {
throw hookErrors
}
}

async function callAroundAllHooks(
Expand Down
Loading
Loading