Skip to content

docs: trace mark integration with vitest-browser-react/vue/svelte#9828

Merged
sheremet-va merged 3 commits intovitest-dev:mainfrom
hi-ogawa:03-09-docs_trace_mark_integration_with_vitest-browser-react_vue_svelte
Mar 10, 2026
Merged

docs: trace mark integration with vitest-browser-react/vue/svelte#9828
sheremet-va merged 3 commits intovitest-dev:mainfrom
hi-ogawa:03-09-docs_trace_mark_integration_with_vitest-browser-react_vue_svelte

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Mar 9, 2026 •
edited
Loading

Description

Docs for

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 9, 2026 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8d97beb
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69afb099538e630008204277
😎 Deploy Preview https://deploy-preview-9828--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review March 9, 2026 08:36
sheremet-va
sheremet-va requested changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sheremet-va sheremet-va left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should replace all sync usage with async, leaving a note that sync is still supported, but deprecated. In the next major, it will be async instead.

Should've done that a long time ago, to be honest.

@hi-ogawa
Copy link
Copy Markdown
Collaborator Author

hi-ogawa commented Mar 10, 2026

Sounds reasonable since their rerender turns out to be already promise and we are all in async rendering age anyways. Will update.

hi-ogawa and others added 2 commits March 10, 2026 11:49
@hi-ogawa
Merge branch 'main' into 03-09-docs_trace_mark_integration_with_vites…
466f3fd 
…t-browser-react_vue_svelte
@hi-ogawa @claude
docs: deprecate sync render usage in vue/svelte browser packages
8d97beb 
Update docs to always use `await render()` and add deprecation
warnings for synchronous usage of render, rerender, and unmount.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sheremet-va sheremet-va merged commit 228067e into vitest-dev:main Mar 10, 2026
10 checks passed
@hi-ogawa hi-ogawa deleted the 03-09-docs_trace_mark_integration_with_vitest-browser-react_vue_svelte branch March 10, 2026 08:17
@hi-ogawa hi-ogawa mentioned this pull request Apr 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hi-ogawa @sheremet-va