Feature request: Hide storage notification and other pop-up

[chrrybmb64]

The "Disable Proton upsell ads" setting is great, but there are two things I've noticed that it doesn't hide.

This Proton Drive low storage notification in the botton left:

And this unremovable pop-up in the bottom right.

Closing the drive notification every time I check my email has become rather annoying. It would be nice if these could be hidden as well. Thank you for maintaining this project.

[vladimiry]

I don't use Drive at all, so it was hard to notice it there. Will have to look into it.

Closing the drive notification every time I check my email has become rather annoying.

In some cases, Proton saves state of the alike kind in the local storage (vs on the server), which the app by design doesn't keep between the restarts.

[vladimiry]

I believe displayed upsell messages will be taken care of in the new app release, as I've just applied the disabling logic to them in the patches. It's already available in the wip branch.

[chrrybmb64]

I'm sorry to report that after updating to 5.3.1 the displayed messages are still appearing, and there is also a new one across the top of the window.

[vladimiry]

It's fine to report again. I couldn't get the same messages on my account that you originally displayed, but I found similar stuff in the Proton code and applied filtering to it, hoping that it will be enough to handle most annoying upsell ads cases. But apparently I still missed something.

If interested in code details, the changes I made in relation to this issue are 3 last diff's in https://github.com/vladimiry/ElectronMail/blob/f37ea9501e1ec1bb79e203acc4c96ac7e5ee0bfa/patches/protonmail/upsell.patch

Proton, by the way, devotes a lot of effort to this upsell ads stuff, as there is a lot of not always simple code, scattered across their WebClients repo responsible just for this matter.

So reopening as the original issue didn't get fixed. More Proton code exploring will be needed, or maybe I somehow get the same ad messages you get, so it will be easier to locate/fix/test at my side.

[chrrybmb64]

Two of these messages (the first and the third image) appear when your Proton Drive storage is almost full on free account, so if you get a free account and dump about 2GB of random files into Drive on it you should be able to reproduce them.

The second image, I'm not so sure. It has a different tip or suggestion every time I open the app, and no settings appear to affect it.

[vladimiry]

Ok. I filled a free account with almost 2GB and got displayed the orange top bar and the bottom-left popup, that one with the icon. I'm surprised that these ads displayed even in the Mail app, not just in Drive as I originally thought. So indeed now I understand how annoying this is for Drive users with filled storage. Going to apply filtering logic to these ads.

And this unremovable pop-up in the bottom right.

Got this too, but with another message. Not sure if I should filter out this too, as it doesn't look very annoying. I guess the content of this block gets resolved from the "tips" array I just touched in the original uncomplete "fix".

[vladimiry]

The fix has been pushed to the wip branch, so it can be tested by building the app from source. I might upload an installation package later if needed.

got displayed the orange top bar and the bottom-left popup, that one with the icon

A quick test on my end shows that both ads were successfully suppressed when the corresponding flag was enabled in the app settings. These are Warning-type upsell ads.

Also, it intentionally doesn't suppress Danger-type ads, as these indicate 100% full storage and likely require user attention/action.