Skip to content

issue #149: Added @NgModule declarations… - #160

Open
borisfeldmann wants to merge 1 commit into
vladotesanovic:masterfrom
borisfeldmann:master
Open

issue #149: Added @NgModule declarations…#160
borisfeldmann wants to merge 1 commit into
vladotesanovic:masterfrom
borisfeldmann:master

Conversation

@borisfeldmann

Copy link
Copy Markdown

…to prevent error "NgSemanticModule is not an NgModule"

…or "NgSemanticModule is not an NgModule"
@Tzesar

Tzesar commented Mar 12, 2017

Copy link
Copy Markdown

Can this be merged?
I need it to build my site in a production environment.

@dinever

dinever commented Mar 24, 2017

Copy link
Copy Markdown

👍, I'm getting this error too

Failed to compile.
NgSemanticModule is not an NgModule

@AndreasZaschka

Copy link
Copy Markdown

Hey @Tzesar, @sushanzh
in your package.json use
"ng-semantic": "https://github.com/borisfeldmann/ngSemantic/tarball/master"
and replace the imports of NgSemanticModule from ng-semantic to "ng-semantic/ng-semantic"

@hookedupjoe

hookedupjoe commented Apr 21, 2017

Copy link
Copy Markdown

Is there a reason this change is not merged? I see it has been approved but still can't use this library in the current CLI environment as is. Thanks for the great library, hope to be able to use it soon in an NPM setting.

Edit: Is there a technical reason we can help resolve to be able to merge this in? :)

@JSMike

JSMike commented Apr 29, 2017

Copy link
Copy Markdown

@AndreasZaschka that's not relevant, the package.json file wasn't changed in this PR. please pull it in, it's been almost 3 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants