issue #149: Added @NgModule declarations… - #160
Open
borisfeldmann wants to merge 1 commit into
Open
Conversation
…or "NgSemanticModule is not an NgModule"
AndreasZaschka
approved these changes
Mar 2, 2017
|
Can this be merged? |
|
👍, I'm getting this error too
|
|
Is there a reason this change is not merged? I see it has been approved but still can't use this library in the current CLI environment as is. Thanks for the great library, hope to be able to use it soon in an NPM setting. Edit: Is there a technical reason we can help resolve to be able to merge this in? :) |
|
@AndreasZaschka that's not relevant, the package.json file wasn't changed in this PR. please pull it in, it's been almost 3 months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to prevent error "NgSemanticModule is not an NgModule"