Open
Conversation
Collaborator
|
Can you also force output sample rate (resample) in ffmpeg for both video and audio? |
Collaborator
|
Most likely the flag is -ar 44100 |
egregors
requested changes
Apr 16, 2023
Collaborator
There was a problem hiding this comment.
Looks like the conceptual problem here, a bit bigger than it seems like. When I proposed to think about degradation, I mean the followings:
- Let's say we have an abstract functionality:
nastya-mode - This functionality is a composition of smallest functions: find in the chat right messages, remove messages, ban bastard, translate audio to text, post recognized text.
- And we here the pretty explicit priority:
catch msg -> delete -> ban -> audio-to-text - A degradation of some functionality composition is saving main functions even if other parts are not working properly. In other words, when some part of the composition isn't available, we are degrading the whole functionality by excluding \ skipping broken parts. But the main func still must be done. This is the general idea.
I believe it will be good, if we make a little refactoring to support this mechanic.
So, in our particular example, nastya-mode must in any cases perform catch -> remove -> ban parts, and if it possibly – trying to convert audio to text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for this issue:
400 sample_rate_hertz (48000) in RecognitionConfig must either be omitted or match the value in the WAV header (44100).