Skip to content

[Batch] fix large size validation - #2468

Merged
Jeffwan merged 1 commit into
vllm-project:mainfrom
scarlet25151:feat/fix-large-size-validation
Jul 27, 2026
Merged

[Batch] fix large size validation#2468
Jeffwan merged 1 commit into
vllm-project:mainfrom
scarlet25151:feat/fix-large-size-validation

Conversation

@scarlet25151

Copy link
Copy Markdown
Collaborator

Pull Request Description

[Please provide a clear and concise description of your changes here]
Fix the Frontend error when validating large dataset.
when submitting large file, the validation will failed and return error:
image

after the fix:

image

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces chunked JSONL file parsing (parseJsonlFile) to prevent UI freezing and high memory usage when validating large batch files in the browser. It includes options for timeouts, chunk sizes, and yielding to the main thread, along with corresponding unit tests. The review feedback correctly identifies a potential memory leak and UI thread blocking issue in CreateJob.tsx where a large file's full parse could be cached in the React state during job creation, and suggests removing this state update.

Comment thread apps/console/web/src/components/CreateJob.tsx Outdated
@scarlet25151
scarlet25151 force-pushed the feat/fix-large-size-validation branch from efaf689 to 2afd07f Compare July 26, 2026 18:05
Signed-off-by: chenyu.jiang <chenyu.jiang@bytedance.com>
@scarlet25151
scarlet25151 force-pushed the feat/fix-large-size-validation branch from 2afd07f to 7f63344 Compare July 27, 2026 06:30
@scarlet25151
scarlet25151 requested a review from Jeffwan July 27, 2026 06:48
@Jeffwan
Jeffwan merged commit ebe0c5e into vllm-project:main Jul 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants