[Batch] fix large size validation - #2468
Merged
Jeffwan merged 1 commit intoJul 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces chunked JSONL file parsing (parseJsonlFile) to prevent UI freezing and high memory usage when validating large batch files in the browser. It includes options for timeouts, chunk sizes, and yielding to the main thread, along with corresponding unit tests. The review feedback correctly identifies a potential memory leak and UI thread blocking issue in CreateJob.tsx where a large file's full parse could be cached in the React state during job creation, and suggests removing this state update.
scarlet25151
force-pushed
the
feat/fix-large-size-validation
branch
from
July 26, 2026 18:05
efaf689 to
2afd07f
Compare
Signed-off-by: chenyu.jiang <chenyu.jiang@bytedance.com>
scarlet25151
force-pushed
the
feat/fix-large-size-validation
branch
from
July 27, 2026 06:30
2afd07f to
7f63344
Compare
Jeffwan
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[Please provide a clear and concise description of your changes here]

Fix the Frontend error when validating large dataset.
when submitting large file, the validation will failed and return error:
after the fix:
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.