Skip to content

[Batch] Fix runtime timeout setting - #2492

Merged
Jeffwan merged 2 commits into
vllm-project:mainfrom
scarlet25151:fix/batch-runtime-upstream-review
Jul 27, 2026
Merged

[Batch] Fix runtime timeout setting#2492
Jeffwan merged 2 commits into
vllm-project:mainfrom
scarlet25151:fix/batch-runtime-upstream-review

Conversation

@scarlet25151

Copy link
Copy Markdown
Collaborator

Pull Request Description

  • Preserving compatibility with legacy runtime _wait_ready(handle) hooks while still forwarding wait_mode to newer implementations.
  • Adding per-job client.request_timeout_seconds metadata with minimum timeout validation.
  • Adding focused regression tests for readiness hook compatibility and request timeout metadata validation/round-trip behavior.

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces backward compatibility for legacy runtimes by dynamically inspecting whether _wait_ready accepts the wait_mode parameter. It also adds a request_timeout_seconds configuration option to ClientConfig with a minimum value of 1.0 second, supported by new unit tests. Feedback is provided to improve the robustness of the signature inspection by catching broader exceptions and returning a safer fallback value of False to prevent potential runtime errors on legacy implementations.

Comment thread python/aibrix/aibrix/batch/job_driver/runtime/base.py
@scarlet25151
scarlet25151 force-pushed the fix/batch-runtime-upstream-review branch 3 times, most recently from 13f43f7 to 78601ba Compare July 27, 2026 06:05
chenyu.jiang added 2 commits July 26, 2026 23:10
Signed-off-by: chenyu.jiang <chenyu.jiang@bytedance.com>
Signed-off-by: chenyu.jiang <chenyu.jiang@bytedance.com>
@scarlet25151
scarlet25151 force-pushed the fix/batch-runtime-upstream-review branch from 78601ba to f1efc5f Compare July 27, 2026 06:10
@Jeffwan
Jeffwan merged commit fefa955 into vllm-project:main Jul 27, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants