Skip to content

Conversation

@mengniwang95
Copy link

SUMMARY:

  • Support w8a8 static fp8 quantization in auto-round modifier
  • Support w8a8 dynamic fp8 quantization in auto-round modifier
  • Add llama4 w8a8 static/dynamic fp8 quantization example

note: this PR depends on the auto-round PR: intel/auto-round#1161

TEST PLAN:
run the ut: ./tests/llmcompressor/transformers/autoround/test_autoround_oneshot.py

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mengniwang95, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the AutoRoundModifier by introducing support for both static and dynamic w8a8 FP8 quantization schemes. It also includes new Llama4 examples to showcase these capabilities, making the quantization process more versatile for various model architectures and precision requirements.

Highlights

  • W8A8 Static FP8 Quantization Support: The AutoRound modifier now supports w8a8 static FP8 quantization, expanding its capabilities for model compression.
  • W8A8 Dynamic FP8 Quantization Support: The AutoRound modifier now supports w8a8 dynamic FP8 quantization, offering more flexibility in how models are compressed.
  • Llama4 FP8 Quantization Examples: New examples have been added to demonstrate w8a8 static and dynamic FP8 quantization specifically for Llama4 models, providing practical guidance for users.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@mengniwang95 mengniwang95 changed the title [AutoRound] Support more auto-round scheme and add example [AutoRound] Support w8a8 scheme in auto-round and add example Dec 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for w8a8 static and dynamic fp8 quantization to the AutoRound modifier, including new examples and tests. The core logic changes in base.py are significant. My review identified a few issues: a copy-paste error in an example file, a couple of bugs in the new activation quantization logic within base.py, and a removed assertion in a test file that weakens test coverage. Addressing these points will improve the correctness and clarity of the implementation.

Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
@dsikka dsikka added the autoround For any PR / issue related to autoround support label Dec 19, 2025
@dsikka dsikka marked this pull request as ready for review December 19, 2025 01:21
@dsikka dsikka added the fp8 For any issue / PR related to FP8 support label Dec 19, 2025
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Mengni Wang <[email protected]>
act_dynamic = activation_args.dynamic
act_group_size = activation_args.group_size
act_symmetric = activation_args.symmetric
act_bits = activation_args.num_bits
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using act_dynamic = getattr(activation_args, "dynamic", None)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are default values in QuantizationArgs for each parameter. If we use getattr, I think all similar codes should be replaced to keep aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoround For any PR / issue related to autoround support fp8 For any issue / PR related to FP8 support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants