-
Notifications
You must be signed in to change notification settings - Fork 347
[AutoRound] Support w8a8 scheme in auto-round and add example #2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mengni Wang <[email protected]>
Summary of ChangesHello @mengniwang95, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for w8a8 static and dynamic fp8 quantization to the AutoRound modifier, including new examples and tests. The core logic changes in base.py are significant. My review identified a few issues: a copy-paste error in an example file, a couple of bugs in the new activation quantization logic within base.py, and a removed assertion in a test file that weakens test coverage. Addressing these points will improve the correctness and clarity of the implementation.
examples/autoround/quantization_w8a8_fp8/llama4_static_quant_example.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
Signed-off-by: Wang, Mengni <[email protected]>
tests/llmcompressor/transformers/autoround/test_autoround_oneshot.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mengni Wang <[email protected]>
| act_dynamic = activation_args.dynamic | ||
| act_group_size = activation_args.group_size | ||
| act_symmetric = activation_args.symmetric | ||
| act_bits = activation_args.num_bits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using act_dynamic = getattr(activation_args, "dynamic", None)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are default values in QuantizationArgs for each parameter. If we use getattr, I think all similar codes should be replaced to keep aligned.
SUMMARY:
note: this PR depends on the auto-round PR: intel/auto-round#1161
TEST PLAN:
run the ut: ./tests/llmcompressor/transformers/autoround/test_autoround_oneshot.py