Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GLM-5.3-Flash.yaml model configuration. Specifically, it updates the last modified date, adds a speculative configuration argument (--speculative-config) to the guide command, and updates the documentation to reflect that MTP speculative decoding is now supported on MI355X with specific vLLM builds. No review comments were provided, so there is no additional feedback to address.
Update the ROCm guidance now that upstream sparse-MLA dispatch supports MTP verification correctly. 💘 Generated with Crush Assisted-by: Crush:gpt-5.6-sol Signed-off-by: jamesETsmith <james.smith9113@gmail.com>
jamesETsmith
force-pushed
the
jamesETsmith/glm-5.3-flash-mtp-on-rocm
branch
from
September 11, 2026 14:54
19bc6b8 to
d5a3998
Compare
jamesETsmith
marked this pull request as ready for review
September 11, 2026 16:40
Member
|
lgtm! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the obsolete unsupported warning about MTP in the GLM-5.3-Flash MI355X recipe example now that vLLM's ROCm sparse-MLA dispatch fix has merged (see vllm-project/vllm#55239)
Testing
Validation:
node scripts/build-recipes-api.mjs