[BugFix] fix Ascend310P3 error#8181
Conversation
Signed-off-by: HF-001 <1670186653@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a CI failure related to the Ascend310P3 hardware target. By introducing a hardware-specific check, the system now correctly bypasses unsupported Triton kernel compilation for this architecture, defaulting to the appropriate PyTorch fallback path to maintain stability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request introduces a check for Ascend 310P hardware in the GDN chunk meta operations. It bypasses Triton kernel compilation on this specific hardware because the compiler does not currently support it, opting instead for a PyTorch-based fallback path. The review feedback correctly identifies that the PR title and summary do not adhere to the repository's style guide and provides a compliant template.
| import torch | ||
| from vllm.triton_utils import tl, triton | ||
|
|
||
| from vllm_ascend.utils import is_310p |
There was a problem hiding this comment.
Suggested PR Title:
[Ops][BugFix] Fix Ascend310P3 Triton compilation error in GDN chunk metaSuggested PR Summary:
### What this PR does / why we need it?
This PR bypasses Triton kernel compilation for the `_build_final_chunk_indices` operation on Ascend 310P3 hardware. Since `bishengir-compile` does not currently support targeting Ascend 310P3, attempting to compile Triton kernels results in a CI error: `Cannot find option named 'Ascend310P3'`. A PyTorch-based fallback implementation is used instead.
Fixes #7756
### Does this PR introduce _any_ user-facing change?
No. This is a backend-specific fix for Ascend 310P3 hardware compatibility.
### How was this patch tested?
Verified that the logic correctly falls back to the PyTorch implementation when `is_310p()` is true, avoiding the Triton compilation error in CI.This PR does not follow the Repository Style Guide for PR Title and Summary format. Please update the PR title and description accordingly.
References
- The PR title and summary must follow a specific format including [Branch][Module][Action] prefixes and a structured summary body. (link)
Signed-off-by: HF-001 <1670186653@qq.com>
|
@wangxiyuan hi,this pr is ready, Would it be convenient for you to take a look? |
What this PR does / why we need it?
fix ci error: Cannot find option named 'Ascend310P3'. The issues introduced by this PR's modifications: #7756