Skip to content

[Benchmark] DiT models Performance benchmark(T2I/I2I/T2V/TI2V)#362

Merged
hsliuustc0106 merged 30 commits intovllm-project:mainfrom
david6666666:benchmark_dit
Dec 25, 2025
Merged

[Benchmark] DiT models Performance benchmark(T2I/I2I/T2V/TI2V)#362
hsliuustc0106 merged 30 commits intovllm-project:mainfrom
david6666666:benchmark_dit

Conversation

@david6666666
Copy link
Collaborator

@david6666666 david6666666 commented Dec 18, 2025

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

support RFC #344

Test Plan

vllm serve Tongyi-MAI/Z-Image-Turbo --omni --port 8091 --cache-backend cache_dit
python3 benchmarks/benchmark_serving.py \
        --dataset vbench --task t2i --num-prompts 10 \
        --height 1024 --width 1024
vllm serve Qwen/Qwen-Image-Edit  --omni --port 8091 --cache-backend cache_dit
python3 benchmarks/benchmark_serving.py \
       --dataset vbench --task i2i --num-prompts 10 
vllm serve Wan-AI/Wan2.2-T2V-A14B-Diffusers --omni --port 8091 --cache-backend cache_dit
python3 benchmarks/benchmark_serving.py \
    --dataset vbench --task t2v --num-prompts 10 \
    --height 480 --width 640 --fps 16 --num-frames 80

Test Result

image image image
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@david6666666
Copy link
Collaborator Author

david6666666 commented Dec 19, 2025

TOTO:

@david6666666 david6666666 linked an issue Dec 19, 2025 that may be closed by this pull request
1 task
@david6666666 david6666666 force-pushed the benchmark_dit branch 6 times, most recently from b50c622 to a7f79dd Compare December 24, 2025 06:33
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
@david6666666
Copy link
Collaborator Author

close for test

Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
@david6666666 david6666666 reopened this Dec 24, 2025
@david6666666 david6666666 marked this pull request as ready for review December 24, 2025 09:48
Signed-off-by: David Chen <530634352@qq.com>
@david6666666 david6666666 changed the title [WIP][Benchmark] DiT models Performance benchmark(T2I/I2I/T2V/TI2V) [Benchmark] DiT models Performance benchmark(T2I/I2I/T2V/TI2V) Dec 24, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +286 to +288
if len(data) < self.args.num_prompts:
factor = (self.args.num_prompts // len(data)) + 1
data = data * factor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard empty dataset before resizing

When no I2V data is found and PIL is missing, _create_dummy_data() returns an empty list, which then flows into _resize_data() and triggers a ZeroDivisionError at self.args.num_prompts // len(data). This means running the benchmark without a dataset path on a machine lacking PIL (or with an empty dataset directory) will crash before any requests are sent. Consider handling len(data) == 0 explicitly (e.g., return early or raise a clearer error) to avoid this failure.

Useful? React with 👍 / 👎.

@david6666666
Copy link
Collaborator Author

@hsliuustc0106 @ZJY0516 PTAL

Copy link
Member

@ZJY0516 ZJY0516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename this file name to diffusion_benchmark_serving.py or something else

Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
@david6666666 david6666666 added the ready label to trigger buildkite CI label Dec 25, 2025
@david6666666
Copy link
Collaborator Author

pr ready ptal, thx

Signed-off-by: David Chen <530634352@qq.com>
@hsliuustc0106 hsliuustc0106 merged commit beb474b into vllm-project:main Dec 25, 2025
7 checks passed
yenuo26 pushed a commit to yenuo26/vllm-omni that referenced this pull request Dec 29, 2025
…project#362)

Signed-off-by: David Chen <530634352@qq.com>
Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Signed-off-by: wangyu31577 <wangyu31577@hundsun.com>
@david6666666 david6666666 deleted the benchmark_dit branch December 30, 2025 02:47
princepride pushed a commit to princepride/vllm-omni that referenced this pull request Jan 10, 2026
…project#362)

Signed-off-by: David Chen <530634352@qq.com>
Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: DiT models Performance benchmark(T2I/I2I/T2V/TI2V)

3 participants