[Benchmark] DiT models Performance benchmark(T2I/I2I/T2V/TI2V)#362
[Benchmark] DiT models Performance benchmark(T2I/I2I/T2V/TI2V)#362hsliuustc0106 merged 30 commits intovllm-project:mainfrom
Conversation
3a39076 to
d2adf20
Compare
|
TOTO:
|
b50c622 to
a7f79dd
Compare
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
cdc4f83 to
eec6694
Compare
|
close for test |
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
d26e4ba to
4c1732f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if len(data) < self.args.num_prompts: | ||
| factor = (self.args.num_prompts // len(data)) + 1 | ||
| data = data * factor |
There was a problem hiding this comment.
Guard empty dataset before resizing
When no I2V data is found and PIL is missing, _create_dummy_data() returns an empty list, which then flows into _resize_data() and triggers a ZeroDivisionError at self.args.num_prompts // len(data). This means running the benchmark without a dataset path on a machine lacking PIL (or with an empty dataset directory) will crash before any requests are sent. Consider handling len(data) == 0 explicitly (e.g., return early or raise a clearer error) to avoid this failure.
Useful? React with 👍 / 👎.
|
@hsliuustc0106 @ZJY0516 PTAL |
ZJY0516
left a comment
There was a problem hiding this comment.
We should rename this file name to diffusion_benchmark_serving.py or something else
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
Signed-off-by: David Chen <530634352@qq.com>
|
pr ready ptal, thx |
…project#362) Signed-off-by: David Chen <530634352@qq.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com> Signed-off-by: wangyu31577 <wangyu31577@hundsun.com>
…project#362) Signed-off-by: David Chen <530634352@qq.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
support RFC #344
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)