Skip to content

[Bugfix] Fix broken internvl2 inference with v1 #12360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 1 commit into from
Jan 23, 2025
Merged

[Bugfix] Fix broken internvl2 inference with v1 #12360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions vllm/multimodal/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,8 +503,13 @@ def modality_group_func(mm_input: "MultiModalKwargs") -> Union[str, int]:
if len(mm_input.modalities) > 1:
return id(mm_input)

# Otherwise return the modality string
return list(mm_input.modalities)[0]
elif len(mm_input.modalities) == 1:
return list(mm_input.modalities)[0]

# FIXME(Isotr0py): Modality of mm_input from legacy pipeline is empty,
# this is used to make InternVL with legacy pipeline still work with v1.
else:
return ""

return [
list(group) for _, group in groupby(mm_inputs, key=modality_group_func)
Expand Down
Loading