Add support for conversation-template argument for openai endpoint #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o a json template. Added to quickstart.rst and example json file in the examples folder.
This was referenced Oct 9, 2023
|
Going to cancel this PR, and work on another which properly implements the HF chat templates within the tokenizer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a PR for support for conversation-templates setup as json files which can be specified for a model upon starting the api. Just create your template, and pass in the path with the --conversation-template my_template.json argument.
There was no where for me to add support for this in the vLLM api, so I only added it to the OpenAI api.
Added an example, and updated the quickstart part of the readme (the only place that talked about the other arguments)