[MISC] Make GroupCoordinator compatible with out-of-tree devices#16464
Merged
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: hzji210@gmail.com <hzji210@gmail.com>
ji-huazhong
changed the title
DarkLight1337
approved these changes
Apr 12, 2025
DarkLight1337
left a comment
DarkLight1337
left a comment
Member
There was a problem hiding this comment.
Can we remove the TODO comment?
Signed-off-by: hzji210@gmail.com <hzji210@gmail.com>
github-actions
Bot
added
the
ready
Contributor
Author
done :) |
wangxiyuan
pushed a commit
to vllm-project/vllm-ascend
that referenced
this pull request
Apr 17, 2025
This is the first step to support trl vllm serve on Ascend NPU #459. This PR can work properly only when vllm-project/vllm#16464 is merged into vLLM. --------- Signed-off-by: hzji210@gmail.com <hzji210@gmail.com>
yangw-dev
pushed a commit
to yangw-dev/vllm
that referenced
this pull request
Apr 21, 2025
…m-project#16464) Signed-off-by: hzji210@gmail.com <hzji210@gmail.com> Signed-off-by: Yang Wang <elainewy@meta.com>
ttanzhiqiang
pushed a commit
to ttanzhiqiang/vllm-ascend
that referenced
this pull request
Apr 27, 2025
This is the first step to support trl vllm serve on Ascend NPU vllm-project#459. This PR can work properly only when vllm-project/vllm#16464 is merged into vLLM. --------- Signed-off-by: hzji210@gmail.com <hzji210@gmail.com>
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Apr 29, 2025
…m-project#16464) Signed-off-by: hzji210@gmail.com <hzji210@gmail.com>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Apr 29, 2025
…m-project#16464) Signed-off-by: hzji210@gmail.com <hzji210@gmail.com>
RichardoMrMu
pushed a commit
to RichardoMrMu/vllm
that referenced
this pull request
May 12, 2025
…m-project#16464) Signed-off-by: hzji210@gmail.com <hzji210@gmail.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
This is the first step to support trl vllm serve on Ascend NPU vllm-project#459. This PR can work properly only when vllm-project/vllm#16464 is merged into vLLM. --------- Signed-off-by: hzji210@gmail.com <hzji210@gmail.com>
yangzhe-2026
pushed a commit
to yangzhe-2026/vllm-ascend
that referenced
this pull request
May 6, 2026
This is the first step to support trl vllm serve on Ascend NPU vllm-project#459. This PR can work properly only when vllm-project/vllm#16464 is merged into vLLM. --------- Signed-off-by: hzji210@gmail.com <hzji210@gmail.com>
nanxingMy
pushed a commit
to nanxingMy/vllm-ascend
that referenced
this pull request
May 15, 2026
This is the first step to support trl vllm serve on Ascend NPU vllm-project#459. This PR can work properly only when vllm-project/vllm#16464 is merged into vLLM. --------- Signed-off-by: hzji210@gmail.com <hzji210@gmail.com> Signed-off-by: nanxing <1014662416@qq.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
…m-project#16464) Signed-off-by: hzji210@gmail.com <hzji210@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working on making vllm-ascend support rlhf-related functions, and a key step is to provide functions similar to PyHcclComunicator. When migrating the test cases related to test_pynccl in vLLM, I found that GroupCoordinator seems incompatible with out-of-tree devices. (see:https://github.com/vllm-project/vllm-ascend/actions/runs/14406599923/job/40404534132?pr=503). This PR has fixed this issue.
cc @youkaichao @DarkLight1337