Skip to content

[CI/Build] Reorganize models tests #17459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 1, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 30, 2025

  • Instead of nesting by <arch/task> -> <modality>, we now nest the directories by <modality> -> <task> to better align with our test grouping in CI.
  • Combine audio and vision test directories together since some models support both.
  • Don't separate by architecture anymore since V1 should have built-in encoder-decoder support.
  • Quantization models tests have been moved into a separate directory tests/models/quantization, removing the need for quant_model pytest mark since they can now be conveniently selected.
  • Also, fix a bunch of failing model tests

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added ci/build multi-modality Related to multi-modality (#4194) labels Apr 30, 2025
Signed-off-by: DarkLight1337 <[email protected]>
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Let's add missing mixed modality for other omni models in a following PR!

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@NickLucche
Copy link
Contributor

V1 should have built-in encoder-decoder support

Are you referring to MM vit encoder + text decoder? Because I missed the news about good old encoder-decoder support on V1 🤔

@DarkLight1337
Copy link
Member Author

V1 should have built-in encoder-decoder support

Are you referring to MM vit encoder + text decoder? Because I missed the news about good old encoder-decoder support on V1 🤔

From my understanding (correct me if I'm wrong @ywang96 ), the V1 model runner is designed to accommodate models that use cross-attention without having to define a separate encoder-decoder model runner.

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 30, 2025
@DarkLight1337 DarkLight1337 requested a review from mgoin April 30, 2025 16:40
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@vllm-bot vllm-bot merged commit afb4429 into vllm-project:main May 1, 2025
3 of 6 checks passed
@DarkLight1337 DarkLight1337 deleted the reorganize-models-tests branch May 1, 2025 06:03
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants