Skip to content

Update test requirements to CUDA 12.8 #17576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2025
Merged

Conversation

22quinn
Copy link
Contributor

@22quinn 22quinn commented May 2, 2025

This is a follow-up fix to #16859
By default, it will install torch with CUDA 12.6

Copy link

github-actions bot commented May 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 2, 2025
@houseroad
Copy link
Collaborator

@huydhn could you take a look?

@houseroad
Copy link
Collaborator

Also lint?

@huydhn
Copy link
Contributor

huydhn commented May 2, 2025

I don't think test.txt file can be updated like this directly. You will need to update test.in and let precommit does the job or generate the file manually with uv pip compile requirements.in -o requirements.txt --index-strategy unsafe-best-match

However, the bigger issue here is that while vLLM CI uses CUDA 12.8. PyTorch default is still 12.6, causing this discrepancy. I have been working around this by using uv pip install -r requirements/dev.txt --extra-index-url https://download.pytorch.org/whl/cu128 instead, i.e. https://github.com/vllm-project/vllm/blob/main/docker/Dockerfile#L177

@22quinn
Copy link
Contributor Author

22quinn commented May 2, 2025

@huydhn I tried using extra-index-url, but always got torch 2.7 cu126 installed. Also there were a bunch of CUDA dependencies in test.txt not matching CUDA 12.8, e.g. nvidia-cuda-runtime-cu12==12.6.77

I think need to modify the hook by adding --torch-backend cu128 unless there's a way to specify this in in file

22quinn added 3 commits May 2, 2025 10:50
Signed-off-by: 22quinn <[email protected]>
Signed-off-by: 22quinn <[email protected]>
Signed-off-by: 22quinn <[email protected]>
@huydhn
Copy link
Contributor

huydhn commented May 2, 2025

From what I read in their doc https://docs.astral.sh/uv/guides/integration/pytorch/#automatic-backend-selection, does --torch-backend auto work for you (I haven't tried that before)? If it does, it would look nicer as you don't need to hardcode cu128 in test.txt. Maybe we want to try it out. If it doesn't work, then the current revision LGTM

@22quinn
Copy link
Contributor Author

22quinn commented May 2, 2025

discussed with Huy offline, this PR is needed as it unifies the version of other cuda dependencies like nvidia-cuda-runtime-cu12

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label May 2, 2025
@houseroad houseroad enabled auto-merge (squash) May 2, 2025 21:02
@vllm-bot vllm-bot merged commit d47b605 into vllm-project:main May 3, 2025
98 of 100 checks passed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants