Repository navigation
[Bugfix] Fix GLM4.1V multimodal processor with compatability for Transformers v4.56 - #24822
Merged
Merged
Conversation
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Isotr0py
marked this pull request as ready for review
September 14, 2025 18:04
Isotr0py
requested review from
DarkLight1337,
NickLucche and
ywang96
as code owners
September 14, 2025 18:04
Member
|
Let's see if transformers nightly passes now |
Member
|
Well, Intern-S1 is still failing, so can't check it |
Member
|
Oh, this breaks the existing processor test |
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Member
Author
I see, let me check it with nightly Transformers locally then. |
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Member
Author
|
Have confirmed v4.56.1 and v4.57.0.dev(huggingface/transformers@9c804f7) can still pass the GLM4.1V tests in |
DarkLight1337
approved these changes
Sep 15, 2025
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…sformers v4.56 (vllm-project#24822) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…sformers v4.56 (vllm-project#24822) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…sformers v4.56 (vllm-project#24822) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
…sformers v4.56 (vllm-project#24822) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…sformers v4.56 (vllm-project#24822) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Test should pass.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.