Repository navigation
[Bugfix] Fix Qwen3-VL-MoE weight loading for EP - #25300
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the weight loading logic for Qwen3-VL-MoE models when using expert parallelism (EP). The previous implementation of load_fused_expert_weights was too strict, causing weight loading to fail if any expert was not present on a given rank. The change correctly modifies the logic to consider the loading successful if at least one expert's weights are loaded on the rank, which is the expected behavior for expert parallelism. The changes are correct and effectively address the issue. There is also a minor whitespace change to add a newline at the end of a file.
Isotr0py
approved these changes
Sep 20, 2025
Isotr0py
enabled auto-merge (squash)
September 20, 2025 04:05
7 of 12 tasks
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Roger Wang <hey@rogerw.io> Signed-off-by: charlifu <charlifu@amd.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Roger Wang <hey@rogerw.io> Signed-off-by: yewentao256 <zhyanwentao@126.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Roger Wang <hey@rogerw.io>
ptrdlr14
pushed a commit
to ptrdlr14/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Roger Wang <hey@rogerw.io>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
Signed-off-by: Roger Wang <hey@rogerw.io>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: Roger Wang <hey@rogerw.io>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: Roger Wang <hey@rogerw.io> Signed-off-by: yewentao256 <zhyanwentao@126.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
Signed-off-by: Roger Wang <hey@rogerw.io>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Roger Wang <hey@rogerw.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Previously
self.load_fused_expert_weightscheck is too strict and will prevent server from launching with--enable-expert-parallel. This PR fixes it.Test Plan
The MMMU from server launched with/without
--enable-expert-parallelmatched.Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.