[hmellor]

Should fix the RoPE related failures in the Transformers nightly tests by:

• Handling rope_theta when loading v4 custom models in v5
• Patching original_max_position_embeddings for v4 (all models) and v5 (v4 custom models)
• Only add config.rope_parameters if it was present in the config
• Don't assume that config.rope_parameters is always available in model code

Test plan:

• "Basic Model Tests (Extra Initialization)" should pass in CI
• Run all failing tests from https://buildkite.com/vllm/ci/builds/40384/steps/canvas?sid=019ab4aa-a1aa-4e45-b38d-79358caa5ff4 locally and check for RoPE related failures

[gemini-code-assist]

Code Review

This pull request aims to fix an issue with RoPE parameter handling for nightly builds of the transformers library. The change correctly identifies the need to move rope_theta into the rope_parameters dictionary for newer transformers versions. However, the current implementation has a flaw in how it handles interleaved models, which could lead to runtime errors. I've provided a critical review comment with a code suggestion to address this potential bug and ensure the fix is robust for different model architectures.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".