Repository navigation
Use Transformers v5 RoPE standardisation and validation - #30046
Merged
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the need for standardizing and validating RoPE parameters in vllm when using Transformers v5. By explicitly calling standardize_rope_params() and validate_rope() methods, it ensures that custom models, especially those originally designed for Transformers v4, correctly handle RoPE configurations in the newer Transformers environment. The changes also maintain backward compatibility for Transformers v4 installations. This is a crucial update for ensuring robust and consistent behavior across different Transformers versions.
DarkLight1337
approved these changes
Dec 4, 2025
DarkLight1337
enabled auto-merge (squash)
December 4, 2025 10:12
github-actions
Bot
added
the
ready
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…#30046) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…#30046) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
…#30046) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…#30046) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Transformers v5,
PreTrainedConfiginheritsRotaryEmbeddingConfigMixin, which contains standardisation and validation methods for RoPE.These methods are not called automatically on init, so it is up to the modelling code to call these methods. Custom models written for Transformers v4 do not know about, and therefore do not call, these methods.
This PR ensures that these methods are called if the legacy
rope_thetais present so that these custom models are always validated.Resolves Transformesr nightly tests for:
MiniCPMOGteNewModelMiniMaxM2ForCausalLMGteNewForSequenceClassification