Repository navigation
Remove head_mask from Ultravox and Swin - #30764
Merged
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the unused head_mask parameter from the Swin and Ultravox models to ensure forward compatibility with Transformers v5. The changes are straightforward and correctly implemented, removing dead code and simplifying method signatures. The modifications are consistent across all affected files and look good to me.
DarkLight1337
approved these changes
Dec 16, 2025
DarkLight1337
enabled auto-merge (squash)
December 16, 2025 09:40
github-actions
Bot
added
the
ready
Member
|
PTAL at the failing test |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Head masking is:
v5] Remove headmasking huggingface/transformers#41076This PR removes the
head_maskrelatedkwargsfrom Ultravox and Swin for forward compatibility with Transformers v5.