[CI] Fix mypy for vllm/lora

[hmellor]

This change brings us closer to not needing a custom mypy check. Part of #26533

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

[gemini-code-assist]

Code Review

This pull request refactors LoRA (Low-Rank Adaptation) integration across several modules, primarily focusing on type hinting, validation, and internal logic. Key changes include adjusting mypy configuration for the vllm/lora module, enhancing LoRAConfig validation by ensuring max_cpu_loras is an integer and adding a field_validator for None values during delayed initialization, and improving error messages. For FusedMoE layers, the PR updates type hints (e.g., Mapping, str | None), modifies how MoE configuration parameters are accessed, removes functools.partial usage, and adds type: ignore comments for mypy. It also introduces a validation check for tensorizer_dir when loading LoRA models and refines the parse_fine_tuned_lora_name utility. Significant changes in vllm/lora/model_manager.py involve introducing new abstract base classes (SupportsLoRAModel, SupportsMultiModalLoRAModel) to better define LoRA-compatible models, updating type hints for model parameters and internal caches (MutableMapping), and renaming LoRALRUCache to LoRAModelLRUCache while adding a NoneLRUCache. Finally, the PR removes several assert self.quant_method is not None and assert self.moe_quant_config is not None statements in quantization-related files, relying instead on explicit ValueError checks during initialization to ensure these configurations are present.

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[yewentao256]

Please fix the conflicts so that we can get this landed

[hmellor]

Sure, I was waiting to hear from @jeejeelee for what to do about the multimodal type hint.

[jeejeelee]

Sure, I was waiting to hear from @jeejeelee for what to do about the multimodal type hint.

Sorry for the delay response

[hmellor]

Should be good now, I've started CI

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[mergify]

Hi @hmellor, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[yewentao256]

What's the current status? Could you solve the conflicts so that we can land this?

[mergify]

Hi @hmellor, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork