Skip to content

Bump lm-eval version for Transformers v5 compatibility - #33994

Merged
vllm-bot merged 3 commits into
vllm-project:mainfrom
hmellor:bump-lm-eval
Feb 16, 2026
Merged

vllm-bot merged 3 commits into
vllm-project:mainfrom
hmellor:bump-lm-eval

Conversation

@hmellor

@hmellor hmellor commented Feb 6, 2026

Copy link
Copy Markdown
Member

Update lm-eval pin to 0.4.10 so that EleutherAI/lm-evaluation-harness@384118d is included (the previous version imported a class that no longer exists in Transformers v5)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@DarkLight1337
DarkLight1337 enabled auto-merge (squash) February 6, 2026 13:56
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 6, 2026
@mergify

mergify Bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--33994.org.readthedocs.build/en/33994/

@mergify mergify Bot added documentation Improvements or additions to documentation ci/build rocm Related to AMD ROCm labels Feb 6, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Feb 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates the lm-eval package version to 0.4.10 across various build scripts, documentation, and dependency files. This change aligns with the stated goal of ensuring compatibility with Transformers v5. The modifications in requirements/test.txt reflect the updated dependency tree for lm-eval and are expected. Overall, the changes are straightforward and appear to achieve the intended purpose without introducing any high or critical issues.

@DarkLight1337

Copy link
Copy Markdown
Member

@hmellor

hmellor commented Feb 6, 2026

Copy link
Copy Markdown
Member Author

Hmm, I'll look into it

@mergify

mergify Bot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Feb 7, 2026
@hmellor

hmellor commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

Looks like a bug in lm-eval, I've made a PR to fix it EleutherAI/lm-evaluation-harness#3573

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@mergify mergify Bot removed the needs-rebase label Feb 16, 2026
@vllm-bot
vllm-bot merged commit a21cedf into vllm-project:main Feb 16, 2026
106 of 115 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Feb 16, 2026
@hmellor
hmellor deleted the bump-lm-eval branch February 16, 2026 13:43
jiangkuaixue123 pushed a commit to jiangkuaixue123/vllm that referenced this pull request Apr 28, 2026
…t#33994)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
…t#33994)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
…t#33994)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
…t#33994)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants