Repository navigation
Fix Mistral yarn warning in Transformers v5 - #37292
Merged
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Member
Author
|
@juliendenize could you please confirm that this fix works for you? |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a warning from newer versions of the transformers library for Mistral models using YaRN scaling. It does so by adding ignore_keys_at_rope_validation to the model configuration. My review suggests adding a version guard to this change to ensure compatibility across different transformers versions.
hmellor
commented
Mar 18, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
juliendenize
approved these changes
Mar 19, 2026
juliendenize
left a comment
juliendenize
left a comment
Contributor
There was a problem hiding this comment.
Hey sorry took a bit of time to answer was off for two days 😄
I had to change to make it >5.2.0 for it to work, hence my suggestion. This is due to 5.3.0.dev being < 5.3.0.
Thanks for finding a clean, Transformers native, solution !
Co-authored-by: Julien Denize <40604584+juliendenize@users.noreply.github.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
enabled auto-merge (squash)
April 7, 2026 11:53
github-actions
Bot
added
the
ready
DarkLight1337
approved these changes
Apr 7, 2026
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Julien Denize <40604584+juliendenize@users.noreply.github.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Julien Denize <40604584+juliendenize@users.noreply.github.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Julien Denize <40604584+juliendenize@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of huggingface/transformers#41250 the
ignore_keysargument tovalidate_ropewas removed in favour ofClassVars attached to the config classes themselves.This PR sets this new
ClassVarfor Mistral models which useyarnso that the warning from Transformers RoPE validation is suppressed.cc @juliendenize