Repository navigation
[MRV2] Use fp32 for draft logits - #37526
Merged
Merged
Conversation
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request successfully addresses the concern regarding the safety of downcasting draft_logits to BF16 by explicitly setting their data type to torch.float32. This change ensures that the draft logits are always processed in FP32, mitigating potential issues until BF16 verification is complete. The modifications are clear and directly align with the stated objective of the pull request.
chooper26
pushed a commit
to intellistream/vllm-hust-legacy-20260831
that referenced
this pull request
Mar 21, 2026
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We haven't verified the safety of downcasting draft_logits to BF16. Hence, we should use fp32 for now.