Skip to content

[Bugfix] RoBERTa position_id accumulation in CUDA graph padding region #37873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Isotr0py merged 3 commits into from
Mar 23, 2026
+2 −0
Merged

[Bugfix] RoBERTa position_id accumulation in CUDA graph padding region #37873

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24192be
[Bugfix] Zero out CUDA graph padding positions to prevent RoBERTa pos…
yanghui1-arch Mar 23, 2026
e0900d9
Merge branch 'main' into fix/roberta-position-accumulation-cuda-graph
yanghui1-arch Mar 23, 2026
8788459
Merge branch 'main' into fix/roberta-position-accumulation-cuda-graph
yanghui1-arch Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vllm/v1/worker/gpu_model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3084,6 +3084,8 @@ def _preprocess(
positions = self.xdrope_positions.gpu[:, :num_input_tokens]
else:
positions = self.positions.gpu[:num_input_tokens]
if num_input_tokens > num_scheduled_tokens:
self.positions.gpu[num_scheduled_tokens:num_input_tokens].zero_()

if is_first_rank:
intermediate_tensors = None
Expand Down
Loading