[ronensc]

Purpose

Follow up on #39185

OffloadingManager already accepts req_context: ReqContext on the three "initiation" methods (lookup, prepare_load, prepare_store) but not on the three "completion/maintenance" methods (touch, complete_load, complete_store).
This PR closes that gap so the full interface is consistent and future manager implementations can act on per-request context during completion callbacks.

Test Plan

pytest -s -v tests/v1/kv_offload/cpu/test_manager.py

Test Result

tests/v1/kv_offload/cpu/test_manager.py::test_already_stored_block_not_evicted_during_prepare_store[lru] PASSED
tests/v1/kv_offload/cpu/test_manager.py::test_already_stored_block_not_evicted_during_prepare_store[arc] PASSED
tests/v1/kv_offload/cpu/test_manager.py::test_cpu_manager PASSED
tests/v1/kv_offload/cpu/test_manager.py::TestARCPolicy::test_basic PASSED
tests/v1/kv_offload/cpu/test_manager.py::TestARCPolicy::test_t1_to_t2_promotion PASSED
tests/v1/kv_offload/cpu/test_manager.py::TestARCPolicy::test_eviction_with_load PASSED
tests/v1/kv_offload/cpu/test_manager.py::TestARCPolicy::test_adaptive_target PASSED
tests/v1/kv_offload/cpu/test_manager.py::TestARCPolicy::test_t1_t2_eviction_policy PASSED
tests/v1/kv_offload/cpu/test_manager.py::TestARCPolicy::test_ghost_list_bounds PASSED
tests/v1/kv_offload/cpu/test_manager.py::TestARCPolicy::test_touch_ordering PASSED
tests/v1/kv_offload/cpu/test_manager.py::TestARCPolicy::test_failed_store PASSED
tests/v1/kv_offload/cpu/test_manager.py::TestARCPolicy::test_full_scenario PASSED
tests/v1/kv_offload/cpu/test_manager.py::test_filter_reused_manager PASSED

---

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

[claude]

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

[gemini-code-assist]

Code Review

This pull request updates the KV offloading interface and its implementations to include a ReqContext parameter in the touch, complete_load, and complete_store methods. These changes ensure that per-request context is consistently passed through the offloading manager, with corresponding updates applied to the scheduler and test suite. I have no feedback to provide as there are no review comments to evaluate.

[mergify]

Hi @ronensc, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

[mergify]

Hi @ronensc, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

[mergify]

Hi @ronensc, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

[mergify]

Hi @ronensc, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?

mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10