Skip to content

Fix DeepSeek-OCR for Transformers v4#41460

Merged
Isotr0py merged 4 commits into
vllm-project:mainfrom
hmellor:fix-deepseek-ocr
May 5, 2026
Merged

Fix DeepSeek-OCR for Transformers v4#41460
Isotr0py merged 4 commits into
vllm-project:mainfrom
hmellor:fix-deepseek-ocr

Conversation

@hmellor
Copy link
Copy Markdown
Member

@hmellor hmellor commented May 1, 2026

Fixes DeepSeek-OCR for Transformers v4 which was resetting model_type to deepseek_vl_v2 in super().__init__(**kwargs)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@mergify mergify Bot added the deepseek Related to DeepSeek models label May 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request refactors the DeepseekVLV2Config class by streamlining the init method, specifically inlining the extraction of sub-configs and updating the logic for model_type and architectures. Feedback identifies potential TypeError vulnerabilities when handling None values within kwargs for architectures and configuration keys, recommending more robust dictionary access patterns.

Comment thread vllm/transformers_utils/configs/deepseek_vl2.py
Comment thread vllm/transformers_utils/configs/deepseek_vl2.py
@hmellor hmellor changed the title Fix DeepSeek-OCR Fix DeepSeek-OCR for Transformers v4 May 1, 2026
@Isotr0py Isotr0py enabled auto-merge (squash) May 2, 2026 02:06
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 2, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 4, 2026

Hi @hmellor, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

@Isotr0py Isotr0py merged commit b0765be into vllm-project:main May 5, 2026
47 checks passed
@hmellor hmellor deleted the fix-deepseek-ocr branch May 5, 2026 11:26
chaojun-zhang pushed a commit to chaojun-zhang/vllm that referenced this pull request May 6, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copilot AI pushed a commit to hongbolv/vllm that referenced this pull request May 7, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: hongbolv <33214277+hongbolv@users.noreply.github.com>
ikaadil pushed a commit to ikaadil/vllm that referenced this pull request May 7, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
libinta pushed a commit to libinta/vllm that referenced this pull request May 8, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Libin Tang <libin.tang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deepseek Related to DeepSeek models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants