[XPU] fix weight scale shape#42725
Merged
Merged
Conversation
Signed-off-by: Zhu, Zufang <zufang.zhu@intel.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the process_weights_after_loading method in the XPU scaled matrix multiplication kernel to transpose and update the weight_scale parameter. A review comment points out that this transformation is currently performed unconditionally, which could lead to incorrect tensor shapes if the weight is already in the target layout. The reviewer suggests moving the weight_scale transposition inside the conditional block to ensure it remains consistent with the weight's layout.
jikunshang
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update weight scale shape
Test CI