Repository navigation
[Misc] Replace assert with proper exceptions for security and validation in pooling #43286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
noooop
merged 7 commits into
vllm-project:main
from
taneem-ibrahim:pooling-error-handling
May 22, 2026
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e4e2015
Replace assert with proper exceptions for security and validation
taneem-ibrahim b17778d
Merge branch 'main' into pooling-error-handling
taneem-ibrahim ac6bfb6
Merge branch 'main' into pooling-error-handling
njhill 5c4a76b
Merge branch 'main' into pooling-error-handling
taneem-ibrahim a51bdeb
Merge branch 'main' into pooling-error-handling
taneem-ibrahim 5b8dbe7
Fix CI test failure by replacing AssertionError with ValueError
taneem-ibrahim 924e23e
Merge branch 'main' into pooling-error-handling
taneem-ibrahim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
__post_init__method is not a standard hook formsgspec.Structand will not be automatically executed upon instantiation. This means the validation foroutput_kindis currently ineffective. Consider moving this check to theverify()method or another validation path that is explicitly called during the request processing lifecycle.