Skip to content

add epilogue hook to flex attention - #45841

Merged
vllm-bot merged 4 commits into
vllm-project:mainfrom
liangel-02:flex_attn_sinks
Jul 28, 2026
Merged

vllm-bot merged 4 commits into
vllm-project:mainfrom
liangel-02:flex_attn_sinks

Conversation

@liangel-02

@liangel-02 liangel-02 commented Jun 16, 2026 •

Copy link
Copy Markdown
Contributor

adding optional post-attention epilogue transform to flex attention (this is an example of how someone could use this)

@mergify

mergify Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--45841.org.readthedocs.build/en/45841/

@mergify

mergify Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @liangel-02.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Jun 17, 2026
@liangel-02 liangel-02 changed the title add attention sinks to flex attention add epilogue hook to flex attention Jun 19, 2026
@liangel-02
liangel-02 marked this pull request as draft June 19, 2026 22:12
Signed-off-by: Angel Li <liangel@meta.com>
@mergify mergify Bot removed the needs-rebase label Jun 19, 2026
@liangel-02
liangel-02 marked this pull request as ready for review July 22, 2026 15:19

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@liangel-02

Copy link
Copy Markdown
Contributor Author

cc @MatthewBonanni

@MatthewBonanni MatthewBonanni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MatthewBonanni MatthewBonanni added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 22, 2026
@MatthewBonanni
MatthewBonanni enabled auto-merge (squash) July 22, 2026 15:52
@vllm-bot
vllm-bot merged commit 9b9fc40 into vllm-project:main Jul 28, 2026
3 of 6 checks passed
michael-gpu pushed a commit to practical-inference/vllm-ampere-extended that referenced this pull request Oct 20, 2026
Signed-off-by: Angel Li <liangel@meta.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Matthew Bonanni <mbonanni@redhat.com>
Co-authored-by: Michael Goin <mgoin64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants