[ROCm][Bugfix] Fix chunk alignment when using context parallelism with TRITON_MLA#46114
Open
micah-wil wants to merge 4 commits into
Open
[ROCm][Bugfix] Fix chunk alignment when using context parallelism with TRITON_MLA#46114micah-wil wants to merge 4 commits into
micah-wil wants to merge 4 commits into
Conversation
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in mla_attention when using context parallelism on ROCm.
max_context_chunkis being aligned properly on CUDA because of theself.aot_schedulepath (which is CUDA-only). The chunk misalignment causes zero accuracy intest_context_parallel.pyon ROCm with dcp_size=4 usingTRITON_MLA.This PR resolves the issue by shrinking
max_context_chunkto the nearest size that divides evenly across GPUs and lands on a clean cache-block boundary. With this, the above test case is passing. I fixed the corresponding test to not use CUDA-only attention backends as well, and I set the baseline accuracy now that the test successfully runs on ROCm. It was passing but flaky withMIN_ACCURACY=0.64, and after 10 tries the lowest accuracy I saw was about 0.51.