Skip to content

[ROCm][CI] skip moe weight padding for eplb - #49350

Merged
AndreasKaratzas merged 1 commit into
vllm-project:mainfrom
divakar-amd:fix_eplb_weightPadding_main
Jul 22, 2026
Merged

AndreasKaratzas merged 1 commit into
vllm-project:mainfrom
divakar-amd:fix_eplb_weightPadding_main

Conversation

@divakar-amd

Copy link
Copy Markdown
Contributor

This PR skips moe padding for eplb as contiguous weights are required, following a refactoring.

pytest -s -v tests/distributed/test_elastic_ep.py::test_elastic_ep_scaling[sync_eplb]

This PR is the 3rd piece for solving this test case.

  1. [AMD][Bugfix][EPLB] Fix elastic EP scaling accuracy on ROCm #47206 -> Fixes the weight transfer issue.
  2. [ROCm] Upgrade NIXL and UCX #49251 -> Resolves the final accuracy.
  3. This PR -> Fixes the moe api refactoring issue.

Signed-off-by: Divakar Verma <divakar.verma@amd.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the rocm Related to AMD ROCm label Jul 21, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Jul 21, 2026
@AndreasKaratzas AndreasKaratzas added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 21, 2026

@AndreasKaratzas AndreasKaratzas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreasKaratzas
AndreasKaratzas merged commit 53c2f20 into vllm-project:main Jul 22, 2026
115 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Jul 22, 2026
michael-gpu pushed a commit to practical-inference/vllm-ampere-extended that referenced this pull request Oct 20, 2026
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants