Repository navigation
[Core][Distributed] improve p2p access check - #4992
Merged
Merged
Conversation
Member
Author
|
Previously, we use the following check for actual p2p access in case cuda driver is broken: # code partly borrowed from
# https://github.com/turboderp/exllamav2/blob/1c67f97f3d2a968605a9c31ab791a05c85bb7879/exllamav2/compat.py#L10
# License: MIT
def _can_actually_p2p(idx_a, idx_b):
dev_i = f"cuda:{idx_a}"
dev_j = f"cuda:{idx_b}"
a = torch.randn(5, device=dev_i) + 123.0
b = a.to(dev_j)
c = b.to(dev_i)
return torch.all(a == c).cpu().item()However, pytorch somehow fixes the bug, and it will always return import torch
torch.cuda.can_device_access_peer(0, 1) # False
_can_actually_p2p(0, 1) # TrueThis is reported in #4770 (comment) . |
Member
Author
|
cc @hanzhi713 |
Member
Author
|
@WoosukKwon ready for review |
WoosukKwon
approved these changes
May 29, 2024
WoosukKwon
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for the PR! Left some minor comments.
Member
Author
|
@WoosukKwon thanks for the very detailed review! |
Member
Author
|
Since we still don't have ci machines with p2p capability, I tested this PR locally. cc @simon-mo for nvlink machines. |
youkaichao
enabled auto-merge (squash)
May 29, 2024 07:21
chengzhi-lu
pushed a commit
to chengzhi-lu/vllm-infersche
that referenced
this pull request
May 29, 2024
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
May 31, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 8, 2024
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jul 14, 2024
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
shen-shanshan
added a commit
to shen-shanshan/vllm
that referenced
this pull request
Nov 13, 2026
…28 without offloading InferenceX vllm-project#5036 now also runs DP2 at concurrency 128, carried over from the closed vllm-project#4992, with no KV offloading: UMBP did not help there in local runs, since the GPU KV cache holds the working set. Add that point to the mi355x_agentx_dp2_umbp preset with `kv_offload: off`; 256 and 384 keep UMBP. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: shen-shanshan <467638484@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done