Skip to content

[Bugfix] Support HF-config compat for Inkling - #51850

Merged
tlrmchlsmth merged 1 commit into
vllm-project:mainfrom
neuralmagic:inkling-hf-config-compat
Aug 11, 2026
Merged

tlrmchlsmth merged 1 commit into
vllm-project:mainfrom
neuralmagic:inkling-hf-config-compat

Conversation

@mgoin

@mgoin mgoin commented Aug 11, 2026 •

Copy link
Copy Markdown
Member

Purpose

Accept both OG Inkling and Transformers config.json field names for MoE/dense intermediate sizes and conv kernel size, so new quantized checkpoints load without rewriting Hub configs. See https://github.com/huggingface/transformers/blob/fe747d88a3296bd94d426db2717f232f9d4afdb7/src/transformers/models/inkling/configuration_inkling.py#L95 for reference

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: mgoin <mgoin64@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mgoin mgoin added bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed inkling labels Aug 11, 2026
@mgoin

mgoin commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #83403 for commit 0fa77c2382a6.

@mgoin

mgoin commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

/ci retry

@github-actions

Copy link
Copy Markdown

✅ Queued 2 failed job(s) for retry in Buildkite CI #83403.

@tlrmchlsmth
tlrmchlsmth merged commit ded6c45 into vllm-project:main Aug 11, 2026
68 checks passed
michael-gpu pushed a commit to practical-inference/vllm-ampere-extended that referenced this pull request Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working inkling ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants