Repository navigation
[CI] Exclude nvidia-cuda-cccl from the ROCm test lockfile - #64302
Merged
Merged
Conversation
nvidia-nvshmem-cu13 3.8.0 depends on nvidia-cuda-cccl, so pip-compile-rocm now emits it and fails on any change to the ROCm requirements. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Member
|
/ci run |
|
✅ Triggered Buildkite CI #97996 for commit |
Member
Author
|
Should be safe to force merge as the only changes in the requirements file are to comments |
DarkLight1337
approved these changes
Oct 28, 2026
6 tasks done
6 tasks done
6 tasks done
spandantiwari
added a commit
to spandantiwari/vllm
that referenced
this pull request
Oct 29, 2026
Picks up vllm-project#64302, which fixes the pip-compile-rocm pre-commit failure. Signed-off-by: Spandan Tiwari <sptiwari@amd.com> Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix
pip-compile-rocm, which has failed pre-commit onmainand every PR since torch 2.15.0 was released (first failingmainrun).Claims
--no-emit-package torch. uv still picks a torch to resolve torch's transitive dependencies, and takes the newest on PyPI, even though vLLM pins torch 2.14.0 elsewhere.nvidia-nvshmem-cu13==3.7.2, which requiresnvidia-cuda-cccl, and no longer pulls innvidia-curand(2.14.1 hadnvidia-nvshmem-cu13==3.4.5andcuda-toolkit[...,curand,...]).nvidia-cuda-ccclis now excluded like the other CUDA packages, andnvidia-curanddrops out of the lockfile's excluded-packages list. Neither affects what ROCm CI installs.Validation
rocm.txtmatches the diffspip-compile-rocmproduced in CI onmainand [CI] Bump Transformers version to 5.21.1 #64049 (run 1, run 2). I couldn't regenerate it locally because my package mirror resolves older CUDA metadata; this PR's pre-commit run is the check.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code