Repository navigation
Conversation
2 of 6 tasks
Contributor
Author
|
Duplicate of #60873. Agent somehow didn't find it, sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix
compile/fullgraph/test_full_graph.py::test_custom_compile_config[compilation_config3-facebook/opt-125m-model_kwargs3]in CI. E.g. main-branch Buildkite run #98732.Failure was exposed by the automatic fullgraph sharding PR #64635.
Before sharding, the test shared a cache with another test that created an AOT artifact. After sharding, it could run alone with a cold cache and expose a pre-existing
depyf/PyTorch 2.14 incompatibility.Claims
patched_load_by_key_path() got an unexpected keyword argument 'set_sys_modules'.depyf; this is a vLLM compatibility shim until that fix is released.Validation
Pass on both main and this PR because test_
full_graph[facebook/opt-125m-model_kwargs0-3]created an AOT artifact in the shared cache beforetest_custom_compile_config[compilation_config3-facebook/opt-125m-model_kwargs3]ran.Fails on main with
torch._inductor.exc.InductorError: RuntimeError: Failed to run autotuning code block: patched_load_by_key_path() got an unexpected keyword argument 'set_sys_modules'. Passes on this branch.Details
depyf==0.20.0patches Torch Inductor'sPyCodeCache.load_by_key_pathbut does not accept PyTorch 2.14's newset_sys_moduleskeyword. The compatibility shim adds the keyword to the patched wrapper and forwards it to Torch's original loader while preserving depyf's source dumping.The cleanest permanent fix is to update depyf's wrapper and then bump vLLM's depyf dependency and remove the shim.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.