Repository navigation
[Core][Bugfix] Run the warmup dummy forward on every PP rank before the GPU sync check - #66482
Merged
AndreasKaratzas merged 2 commits intoNov 9, 2026
Conversation
…he GPU sync check Only the last PP rank ran an attention-bearing forward before enable_gpu_sync_check(), so lazily built attention state on other ranks was built inside the first checked step. Keep the sampler warmup on the last rank only. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Member
Author
|
/ci retry |
|
✅ No earlier CI build exists for this PR. Use |
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #101011 for commit |
mawong-amd
approved these changes
Nov 9, 2026
mawong-amd
left a comment
Member
There was a problem hiding this comment.
Thanks for the follow-up. Running the warmup forward on every PP rank is the right fix — the first attention-metadata build happens on the first forward, so it has to run before the check arms, and this is the earliest point it can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Run the post-capture warmup dummy forward on every PP rank before
enable_gpu_sync_check(); keep the sampler warmup on the last rank. Follow-up requested in the review of #66397; needed before #64176 turnsVLLM_GPU_SYNC_CHECK=errorback on for AMD CI.Claims
gpu_worker.py:_compile_or_warm_up_modelruns the attention-bearing_dummy_run(max_num_reqs)on every non-pooling PP rank; only the last rank then runs_dummy_sampler_run.test_gpu_worker.py: a non-last and a last PP rank both run a forward before the sync check, and only the last rank runs the sampler. The non-last case fails onmain.Validation
MI350X (gfx950), PP=2, TP=1, eager,
enable_extensible_kv_cache=False,VLLM_GPU_SYNC_CHECK=error:dcp_rank_tensor)GPU<->CPU sync detectedin its firstexecute_modeltests/v1/worker/test_gpu_worker.py+tests/utils_/test_gpu_sync_debug.pytests/distributed/test_pp_cudagraph.py,test_pipeline_parallel.py -k "mp and not Phi-3.5-MoE or mixed_precision"(2 GPUs)Details
On
main, the dummy forward right beforeenable_gpu_sync_check()runs only on the last PP rank, because it came in with the sampler warmup (#62560). With eager mode, JIT warmup off and the extensible KV cache off, nothing else gives the other ranks an attention-bearing forward before the check (the profile run skips attention), so anything built lazily on the first forward is built inside the first checked step and raises there.No in-tree model is known to hit this today: Qwen3-0.6B, DeepSeek-V2-Lite, Nemotron-3-Nano and mamba-130m pass on plain
mainin this configuration, and DSv4.1 is covered already (decoder replay only runs on the last stage, and the DSv4 sparse-MLA warmup runs a forward on every rank). The reproduction above uses a probe to show the ordering gap; this change closes it before the check is enabled rather than fixing an observed model failure. Cost: one extramax_num_reqsforward on non-last ranks at startup (PP rank 0's CUDA-graph build count goes from 22 to 23); startup time stayed within noise.It does not depend on #66397 and can land independently. Not a duplicate: the only open PR touching PP warmup, #54630, changes the seeded sampler pass in
gpu/warmup.py.AI assistance (Claude Code) was used to draft this change. Every line was reviewed by the submitter.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.