Repository navigation
[CI] Only warn on VibeVoice-ASR mixed-length syncs before Transformers 5.23 - #67026
Merged
Merged
Conversation
…s 5.23 huggingface/transformers#50417 removes the sync but is unreleased. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
marked this pull request as ready for review
November 11, 2026 12:33
hmellor
requested review from
AndreasKaratzas,
DarkLight1337 and
ywang96
as code owners
November 11, 2026 12:33
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #101805 for commit ℹ️ This PR is 1 commit behind upstream |
DarkLight1337
approved these changes
Nov 11, 2026
hmellor
enabled auto-merge (squash)
November 11, 2026 12:34
github-actions
Bot
added
the
ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix
test_transformers_audio_mixed_lengthsfailing onmainsince #65735 (build 101707): on Transformers < 5.23 the test runs withVLLM_GPU_SYNC_CHECK=warninstead of the CI image'serror.Claims
get_audio_featuressyncs while removing padding from mixed-length audio. [VibeVoice] Avoid GPU syncs when removing audio padding huggingface/transformers#50417 fixes this but has not been released yet, so the sync check now only warns for this test until then.test_transformers_audio_generation, including VibeVoice-ASR, still runs witherror.Validation
B200, Transformers 5.22.0,
VLLM_GPU_SYNC_CHECK=error(as in the CI image):test_transformers_audio_mixed_lengthsmainRuntimeError: GPU<->CPU sync detectedatmodeling_vibevoice_asr.py:386The FlashInfer JIT doesn't build with the CUDA toolkit on that host, so both runs used
VLLM_USE_FLASHINFER_SAMPLER=0and Triton attention. Neither setting touches the audio encoder, which is where the sync happens.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code