feat: update feedback API to support agent_execution and chat entities #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update submit method to accept optional request_id, agent_execution_id, or chat_id parameters - Update get method to use type parameter and entity ID instead of just requestId - Update TypeScript interfaces to reflect new optional ID fields - Maintain backward compatibility with existing method signatures - Add comprehensive test coverage for new API functionality - Ensure exactly one entity ID is provided in new submit API - Default to 'request' type when using legacy get method signature Refs: vlm-lab PR #1060 Co-Authored-By: [email protected] <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Refactor get and submit methods to utilize options object for better parameter handling - Simplify logic for determining entity IDs and pagination parameters - Update tests to reflect new method signatures and ensure comprehensive coverage - Maintain backward compatibility with existing method signatures Co-Authored-By: [email protected] <[email protected]>
- Update version in package.json from 1.0.0 to 1.0.1 - Introduce comprehensive integration tests for the feedback API, covering various scenarios for getting and submitting feedback - Enhance unit tests to handle undefined notes instead of null Co-Authored-By: VlmRun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: update feedback API to support agent_execution and chat entities
Summary
Updates the Node.js SDK feedback endpoints to support the new API structure from vlm-lab PR #1060. The feedback system now supports three entity types (
request,agent_execution,chat) instead of just requests.Key Changes:
submitmethod: Now accepts optionalrequestId,agentExecutionId, orchatIdparameters (exactly one required)getmethod: Addedtypeparameter to specify entity type ("request","agent_execution","chat")The implementation uses method overloads to support both legacy signatures and new options-based signatures, with runtime type checking to distinguish between them.
Review & Testing Checklist for Human
submit({ agentExecutionId: "...", ... })andget("entity_id", { type: "agent_execution" })work correctly with the deployed vlm-lab backendsubmit(requestId, response, notes)andget(requestId, limit, offset)still works without changesNotes
getmethod now includestype: "request"parameter in API calls - this requires backend support for thetypequery parameterSession: https://app.devin.ai/sessions/bc0fe1ce7d1446e8a741cadf67d46474
Requested by: [email protected]
References: vlm-lab PR #1060