Variable values starting with # are being converted into empty strings

[thiagomarini]

All our slack channels had to urgently go between double quotes because of this commit ccefc51

TECH_CHANNEL=#tech to TECH_CHANNEL="#tech"

[Korbeil]

Wonderfull, what you think about:

TECH_CHANNEL=#tech
TECH_CHANNEL= #comment

If no space => variable,
If space => comment with empty var

Like that, I'll just have to fix the regex and add some tests

@thiagomarini ?

[Korbeil]

Just checked:

○ → export TEST= #bla
○ → echo $TEST

○ → export TEST=#bla
○ → echo $TEST
#bla

This is actually the linux behavior about exporting variables.

[Korbeil]

@GrahamCampbell if you could check if that's ok to you, I have open a PR to fix that as well.
Sorry for the inconvenience

[thiagomarini]

Looks pretty good @Korbeil :)

[murrant]

We are seeing this issue with 2.5.0 too. #277 fixes and looks sane.

[Korbeil]

Why closing ? It's not solved ?