-
-
Notifications
You must be signed in to change notification settings - Fork 646
[2.5] Added the list of environment variable declared inside the 'env' file #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.5] Added the list of environment variable declared inside the 'env' file #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea! Approved ! (some naming remarks though)
* | ||
* @return array | ||
*/ | ||
public function getEnvironmentVariablesList() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have called it getEnvironmentVariableNames
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -102,4 +102,14 @@ public function required($variable) | |||
{ | |||
return new Validator((array) $variable, $this->loader); | |||
} | |||
|
|||
/** | |||
* Get the list of environment variable declared inside the 'env' file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
* | ||
* @var array | ||
*/ | ||
public $variablesList = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variableNames
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Hi @vlucas are you actively maintaining this library any more? |
Thanks. |
@jclebreton Yes, this repo is still actively maintained. :) |
No description provided.