Skip to content

[2.5] Added the list of environment variable declared inside the 'env' file #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2018
Merged

[2.5] Added the list of environment variable declared inside the 'env' file #199

merged 1 commit into from
Jul 1, 2018

Conversation

jclebreton
Copy link
Contributor

No description provided.

Copy link

@etiennecallies etiennecallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea! Approved :shipit: ! (some naming remarks though)

*
* @return array
*/
public function getEnvironmentVariablesList()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have called it getEnvironmentVariableNames

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -102,4 +102,14 @@ public function required($variable)
{
return new Validator((array) $variable, $this->loader);
}

/**
* Get the list of environment variable declared inside the 'env' file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: variables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

*
* @var array
*/
public $variablesList = [];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variableNames ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jclebreton
Copy link
Contributor Author

Hi @vlucas are you actively maintaining this library any more?

@GrahamCampbell GrahamCampbell merged commit 6ae3e2e into vlucas:master Jul 1, 2018
@GrahamCampbell
Copy link
Collaborator

Thanks.

@GrahamCampbell GrahamCampbell changed the title Added the list of environment variable declared inside the 'env' file [2.5] Added the list of environment variable declared inside the 'env' file Jan 28, 2019
@GrahamCampbell
Copy link
Collaborator

@jclebreton Yes, this repo is still actively maintained. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants