Skip to content

[3.1] Fail parser on preg error #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 4, 2019
Merged

[3.1] Fail parser on preg error #308

merged 5 commits into from
Jan 4, 2019

Conversation

GrahamCampbell
Copy link
Collaborator

Replaces #280.

@GrahamCampbell GrahamCampbell changed the title Make the parser class more strict [WIP] Make the parser class more strict Jan 3, 2019
@GrahamCampbell GrahamCampbell changed the title [WIP] Make the parser class more strict [WIP] Fail parser on preg error Jan 3, 2019
@GrahamCampbell
Copy link
Collaborator Author

@danielstokes Could you come up with a test case that causes a preg error please, so we can merge this?

@danielstokes danielstokes mentioned this pull request Jan 4, 2019
Closed
@GrahamCampbell GrahamCampbell changed the title [WIP] Fail parser on preg error Fail parser on preg error Jan 4, 2019
@GrahamCampbell
Copy link
Collaborator Author

Skipping locating the correct error message on super old PHP, and HHVM. I think this is good enough, since we still indicate the error was in the regular expression matching for quote.

@GrahamCampbell GrahamCampbell merged commit 2237795 into vlucas:master Jan 4, 2019
@GrahamCampbell GrahamCampbell deleted the parser-error branch January 4, 2019 20:43
@GrahamCampbell GrahamCampbell changed the title Fail parser on preg error [3.1] Fail parser on preg error Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GrahamCampbell