Skip to content

Remove controller-runtime package #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

XudongLiuHarold
Copy link
Contributor

Signed-off-by: Xudong Liu [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

@XudongLiuHarold XudongLiuHarold force-pushed the remove-controller-runtime-package branch from 7530969 to ee2fa65 Compare June 3, 2022 21:52
Copy link
Contributor

@HanFa HanFa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XudongLiuHarold XudongLiuHarold merged commit ae5d296 into main Jun 3, 2022
@XudongLiuHarold XudongLiuHarold deleted the remove-controller-runtime-package branch June 3, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants