✨ Use priority queue / ctrl-runtime v0.22.3 / 30m resync #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/async-watcher-image-watcher-use-priority-queue
branch
2 times, most recently
from
5ffc31b to
93cc13c
Compare
github-actions
bot
added
size/M
akutz
changed the title
bryanv
approved these changes
Oct 22, 2025
akutz
force-pushed
the
feature/async-watcher-image-watcher-use-priority-queue
branch
2 times, most recently
from
d395a14 to
9ab4a89
Compare
github-actions
bot
added
size/L
akutz
force-pushed
the
feature/async-watcher-image-watcher-use-priority-queue
branch
from
9ab4a89 to
e290349
Compare
github-actions
bot
added
size/M
akutz
force-pushed
the
feature/async-watcher-image-watcher-use-priority-queue
branch
from
e290349 to
c0d1124
Compare
akutz
changed the title
akutz
changed the title
akutz
changed the title
akutz
force-pushed
the
feature/async-watcher-image-watcher-use-priority-queue
branch
from
c0d1124 to
abd2df4
Compare
This patch updates the VM controller to use the controller-runtime priority queue feature by default in combination with v0.22.0 of controller-runtime. This feature ensures that reconcile requests that are not part of an initial list or resync have lower priority than those requests enqueued for any other reason. This should allow VM Operator to handle VM reconciliation when the queues are do large due to a high number of VMs. This patch also changes from a 10m resync to 30m, relying on the async watcher to enqueue VMs for reconciliation in a timely manner. This also means other controllers need to ensure they are properly using requeues / mappers to ensure objects are not relying on resync to refresh status in a timely manner.
akutz
force-pushed
the
feature/async-watcher-image-watcher-use-priority-queue
branch
from
abd2df4 to
5efe7b2
Compare
Minimum allowed line rate is |
akutz
deleted the
feature/async-watcher-image-watcher-use-priority-queue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch updates the VM controller to use the controller-runtime priority queue feature by default in combination with v0.22.3 of controller-runtime. This feature ensures that reconcile requests that are not part of an initial list or resync have lower priority than those requests enqueued for any other reason. This should allow VM Operator to handle VM reconciliation when the queues are do large due to a high number of VMs.
This patch also changes from a 10m resync to 30m, relying on the async watcher to enqueue VMs for reconciliation in a timely manner. This also means other controllers need to ensure they are properly using requeues / mappers to ensure objects are not relying on resync to refresh status in a timely manner.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: